Cleaned up interfaces. Extracted server state machine trigger handler to seperated classes. Removed legacy code
This commit is contained in:
@@ -5,6 +5,7 @@ using MoonCore.Exceptions;
|
||||
using MoonCore.Extended.Abstractions;
|
||||
using MoonCore.Extended.Helpers;
|
||||
using Microsoft.AspNetCore.Authorization;
|
||||
using MoonCore.Extended.Models;
|
||||
using MoonCore.Helpers;
|
||||
using MoonCore.Models;
|
||||
using MoonlightServers.ApiServer.Database.Entities;
|
||||
@@ -32,10 +33,9 @@ public class StarDockerImagesController : Controller
|
||||
|
||||
[HttpGet]
|
||||
[Authorize(Policy = "permissions:admin.servers.stars.get")]
|
||||
public async Task<IPagedData<StarDockerImageDetailResponse>> Get(
|
||||
public async Task<ActionResult<IPagedData<StarDockerImageResponse>>> Get(
|
||||
[FromRoute] int starId,
|
||||
[FromQuery] [Range(0, int.MaxValue)] int page,
|
||||
[FromQuery] [Range(1, 100)] int pageSize
|
||||
[FromQuery] PagedOptions options
|
||||
)
|
||||
{
|
||||
var starExists = StarRepository
|
||||
@@ -43,7 +43,7 @@ public class StarDockerImagesController : Controller
|
||||
.Any(x => x.Id == starId);
|
||||
|
||||
if (!starExists)
|
||||
throw new HttpApiException("No star with this id found", 404);
|
||||
return Problem("No star with this id found", statusCode: 404);
|
||||
|
||||
var query = DockerImageRepository
|
||||
.Get()
|
||||
@@ -51,50 +51,50 @@ public class StarDockerImagesController : Controller
|
||||
|
||||
var count = await query.CountAsync();
|
||||
|
||||
var items = await query
|
||||
var dockerImages = await query
|
||||
.OrderBy(x => x.Id)
|
||||
.Skip(page * pageSize)
|
||||
.Take(pageSize)
|
||||
.Skip(options.Page * options.PageSize)
|
||||
.Take(options.PageSize)
|
||||
.AsNoTracking()
|
||||
.ProjectToAdminResponse()
|
||||
.ToArrayAsync();
|
||||
|
||||
var mappedItems = items
|
||||
.Select(DockerImageMapper.ToAdminResponse)
|
||||
.ToArray();
|
||||
|
||||
return new PagedData<StarDockerImageDetailResponse>()
|
||||
return new PagedData<StarDockerImageResponse>()
|
||||
{
|
||||
Items = mappedItems,
|
||||
CurrentPage = page,
|
||||
PageSize = pageSize,
|
||||
Items = dockerImages,
|
||||
CurrentPage = options.Page,
|
||||
PageSize = options.PageSize,
|
||||
TotalItems = count,
|
||||
TotalPages = count == 0 ? 0 : count / pageSize
|
||||
TotalPages = (int)Math.Ceiling(Math.Max(0, count) / (double)options.PageSize)
|
||||
};
|
||||
}
|
||||
|
||||
[HttpGet("{id:int}")]
|
||||
[Authorize(Policy = "permissions:admin.servers.stars.read")]
|
||||
public async Task<StarDockerImageDetailResponse> GetSingle([FromRoute] int starId, [FromRoute] int id)
|
||||
public async Task<ActionResult<StarDockerImageResponse>> GetSingle([FromRoute] int starId, [FromRoute] int id)
|
||||
{
|
||||
var starExists = StarRepository
|
||||
.Get()
|
||||
.Any(x => x.Id == starId);
|
||||
|
||||
if (!starExists)
|
||||
throw new HttpApiException("No star with this id found", 404);
|
||||
return Problem("No star with this id found", statusCode: 404);
|
||||
|
||||
var dockerImage = await DockerImageRepository
|
||||
.Get()
|
||||
.FirstOrDefaultAsync(x => x.Id == id && x.Star.Id == starId);
|
||||
.Where(x => x.Id == id && x.Star.Id == starId)
|
||||
.ProjectToAdminResponse()
|
||||
.FirstOrDefaultAsync();
|
||||
|
||||
if (dockerImage == null)
|
||||
throw new HttpApiException("No star docker image with this id found", 404);
|
||||
return Problem("No star docker image with this id found", statusCode: 404);
|
||||
|
||||
return DockerImageMapper.ToAdminResponse(dockerImage);
|
||||
return dockerImage;
|
||||
}
|
||||
|
||||
[HttpPost("")]
|
||||
[HttpPost]
|
||||
[Authorize(Policy = "permissions:admin.servers.stars.write")]
|
||||
public async Task<StarDockerImageDetailResponse> Create(
|
||||
public async Task<ActionResult<StarDockerImageResponse>> Create(
|
||||
[FromRoute] int starId,
|
||||
[FromBody] CreateStarDockerImageRequest request
|
||||
)
|
||||
@@ -104,7 +104,7 @@ public class StarDockerImagesController : Controller
|
||||
.FirstOrDefaultAsync(x => x.Id == starId);
|
||||
|
||||
if (star == null)
|
||||
throw new HttpApiException("No star with this id found", 404);
|
||||
return Problem("No star with this id found", statusCode: 404);
|
||||
|
||||
var dockerImage = DockerImageMapper.ToDockerImage(request);
|
||||
dockerImage.Star = star;
|
||||
@@ -116,7 +116,7 @@ public class StarDockerImagesController : Controller
|
||||
|
||||
[HttpPatch("{id:int}")]
|
||||
[Authorize(Policy = "permissions:admin.servers.stars.write")]
|
||||
public async Task<StarDockerImageDetailResponse> Update(
|
||||
public async Task<ActionResult<StarDockerImageResponse>> Update(
|
||||
[FromRoute] int starId,
|
||||
[FromRoute] int id,
|
||||
[FromBody] UpdateStarDockerImageRequest request
|
||||
@@ -127,14 +127,14 @@ public class StarDockerImagesController : Controller
|
||||
.Any(x => x.Id == starId);
|
||||
|
||||
if (!starExists)
|
||||
throw new HttpApiException("No star with this id found", 404);
|
||||
return Problem("No star with this id found", statusCode: 404);
|
||||
|
||||
var dockerImage = await DockerImageRepository
|
||||
.Get()
|
||||
.FirstOrDefaultAsync(x => x.Id == id && x.Star.Id == starId);
|
||||
|
||||
if (dockerImage == null)
|
||||
throw new HttpApiException("No star docker image with this id found", 404);
|
||||
return Problem("No star docker image with this id found", statusCode: 404);
|
||||
|
||||
DockerImageMapper.Merge(request, dockerImage);
|
||||
await DockerImageRepository.Update(dockerImage);
|
||||
@@ -144,22 +144,23 @@ public class StarDockerImagesController : Controller
|
||||
|
||||
[HttpDelete("{id:int}")]
|
||||
[Authorize(Policy = "permissions:admin.servers.stars.write")]
|
||||
public async Task Delete([FromRoute] int starId, [FromRoute] int id)
|
||||
public async Task<ActionResult> Delete([FromRoute] int starId, [FromRoute] int id)
|
||||
{
|
||||
var starExists = StarRepository
|
||||
.Get()
|
||||
.Any(x => x.Id == starId);
|
||||
|
||||
if (!starExists)
|
||||
throw new HttpApiException("No star with this id found", 404);
|
||||
return Problem("No star with this id found", statusCode: 404);
|
||||
|
||||
var dockerImage = await DockerImageRepository
|
||||
.Get()
|
||||
.FirstOrDefaultAsync(x => x.Id == id && x.Star.Id == starId);
|
||||
|
||||
if (dockerImage == null)
|
||||
throw new HttpApiException("No star docker image with this id found", 404);
|
||||
return Problem("No star docker image with this id found", statusCode: 404);
|
||||
|
||||
await DockerImageRepository.Remove(dockerImage);
|
||||
return NoContent();
|
||||
}
|
||||
}
|
||||
@@ -23,18 +23,15 @@ public class StarImportExportController : Controller
|
||||
|
||||
[HttpGet("{starId:int}/export")]
|
||||
[Authorize(Policy = "permissions:admin.servers.stars.get")]
|
||||
public async Task Export([FromRoute] int starId)
|
||||
public async Task<ActionResult> Export([FromRoute] int starId)
|
||||
{
|
||||
var exportedStar = await ImportExportService.Export(starId);
|
||||
|
||||
Response.StatusCode = 200;
|
||||
Response.ContentType = "application/json";
|
||||
await Response.WriteAsync(exportedStar);
|
||||
return Content(exportedStar, "application/json");
|
||||
}
|
||||
|
||||
[HttpPost("import")]
|
||||
[Authorize(Policy = "permissions:admin.servers.stars.create")]
|
||||
public async Task<StarDetailResponse> Import()
|
||||
public async Task<StarResponse> Import()
|
||||
{
|
||||
if (Request.Form.Files.Count == 0)
|
||||
throw new HttpApiException("No file to import provided", 400);
|
||||
|
||||
@@ -4,6 +4,7 @@ using Microsoft.EntityFrameworkCore;
|
||||
using Microsoft.AspNetCore.Authorization;
|
||||
using MoonCore.Exceptions;
|
||||
using MoonCore.Extended.Abstractions;
|
||||
using MoonCore.Extended.Models;
|
||||
using MoonCore.Models;
|
||||
using MoonlightServers.ApiServer.Database.Entities;
|
||||
using MoonlightServers.ApiServer.Mappers;
|
||||
@@ -29,10 +30,9 @@ public class StarVariablesController : Controller
|
||||
|
||||
[HttpGet]
|
||||
[Authorize(Policy = "permissions:admin.servers.stars.get")]
|
||||
public async Task<IPagedData<StarVariableDetailResponse>> Get(
|
||||
public async Task<ActionResult<IPagedData<StarVariableResponse>>> Get(
|
||||
[FromRoute] int starId,
|
||||
[FromQuery] [Range(0, int.MaxValue)] int page,
|
||||
[FromQuery] [Range(1, 100)] int pageSize
|
||||
[FromQuery] PagedOptions options
|
||||
)
|
||||
{
|
||||
var starExists = StarRepository
|
||||
@@ -40,7 +40,7 @@ public class StarVariablesController : Controller
|
||||
.Any(x => x.Id == starId);
|
||||
|
||||
if (!starExists)
|
||||
throw new HttpApiException("No star with this id found", 404);
|
||||
return Problem("No star with this id found", statusCode: 404);
|
||||
|
||||
var query = VariableRepository
|
||||
.Get()
|
||||
@@ -48,29 +48,27 @@ public class StarVariablesController : Controller
|
||||
|
||||
var count = await query.CountAsync();
|
||||
|
||||
var items = await query
|
||||
var variables = await query
|
||||
.OrderBy(x => x.Id)
|
||||
.Skip(page * pageSize)
|
||||
.Take(pageSize)
|
||||
.Skip(options.Page * options.PageSize)
|
||||
.Take(options.PageSize)
|
||||
.AsNoTracking()
|
||||
.ProjectToAdminResponse()
|
||||
.ToArrayAsync();
|
||||
|
||||
var mappedItems = items
|
||||
.Select(StarVariableMapper.ToAdminResponse)
|
||||
.ToArray();
|
||||
|
||||
return new PagedData<StarVariableDetailResponse>()
|
||||
return new PagedData<StarVariableResponse>()
|
||||
{
|
||||
Items = mappedItems,
|
||||
CurrentPage = page,
|
||||
PageSize = pageSize,
|
||||
Items = variables,
|
||||
CurrentPage = options.Page,
|
||||
PageSize = options.PageSize,
|
||||
TotalItems = count,
|
||||
TotalPages = count == 0 ? 0 : count / pageSize
|
||||
TotalPages = (int)Math.Ceiling(Math.Max(0, count) / (double)options.PageSize)
|
||||
};
|
||||
}
|
||||
|
||||
[HttpGet("{id:int}")]
|
||||
[Authorize(Policy = "permissions:admin.servers.stars.get")]
|
||||
public async Task<StarVariableDetailResponse> GetSingle(
|
||||
public async Task<StarVariableResponse> GetSingle(
|
||||
[FromRoute] int starId,
|
||||
[FromRoute] int id
|
||||
)
|
||||
@@ -94,7 +92,7 @@ public class StarVariablesController : Controller
|
||||
|
||||
[HttpPost("")]
|
||||
[Authorize(Policy = "permissions:admin.servers.stars.create")]
|
||||
public async Task<StarVariableDetailResponse> Create([FromRoute] int starId,
|
||||
public async Task<StarVariableResponse> Create([FromRoute] int starId,
|
||||
[FromBody] CreateStarVariableRequest request)
|
||||
{
|
||||
var star = StarRepository
|
||||
@@ -114,7 +112,7 @@ public class StarVariablesController : Controller
|
||||
|
||||
[HttpPatch("{id:int}")]
|
||||
[Authorize(Policy = "permissions:admin.servers.stars.update")]
|
||||
public async Task<StarVariableDetailResponse> Update(
|
||||
public async Task<StarVariableResponse> Update(
|
||||
[FromRoute] int starId,
|
||||
[FromRoute] int id,
|
||||
[FromBody] UpdateStarVariableRequest request
|
||||
|
||||
@@ -4,6 +4,7 @@ using Microsoft.EntityFrameworkCore;
|
||||
using Microsoft.AspNetCore.Authorization;
|
||||
using MoonCore.Exceptions;
|
||||
using MoonCore.Extended.Abstractions;
|
||||
using MoonCore.Extended.Models;
|
||||
using MoonCore.Models;
|
||||
using MoonlightServers.ApiServer.Database.Entities;
|
||||
using MoonlightServers.ApiServer.Mappers;
|
||||
@@ -25,51 +26,48 @@ public class StarsController : Controller
|
||||
|
||||
[HttpGet]
|
||||
[Authorize(Policy = "permissions:admin.servers.stars.read")]
|
||||
public async Task<IPagedData<StarDetailResponse>> Get(
|
||||
[FromQuery] [Range(0, int.MaxValue)] int page,
|
||||
[FromQuery] [Range(1, 100)] int pageSize
|
||||
)
|
||||
public async Task<ActionResult<IPagedData<StarResponse>>> Get([FromQuery] PagedOptions options)
|
||||
{
|
||||
var count = await StarRepository.Get().CountAsync();
|
||||
|
||||
var items = await StarRepository
|
||||
var stars = await StarRepository
|
||||
.Get()
|
||||
.OrderBy(x => x.Id)
|
||||
.Skip(page * pageSize)
|
||||
.Take(pageSize)
|
||||
.Skip(options.Page * options.PageSize)
|
||||
.Take(options.PageSize)
|
||||
.AsNoTracking()
|
||||
.ProjectToAdminResponse()
|
||||
.ToArrayAsync();
|
||||
|
||||
var mappedItems = items
|
||||
.Select(StarMapper.ToAdminResponse)
|
||||
.ToArray();
|
||||
|
||||
return new PagedData<StarDetailResponse>()
|
||||
return new PagedData<StarResponse>()
|
||||
{
|
||||
CurrentPage = page,
|
||||
Items = mappedItems,
|
||||
PageSize = pageSize,
|
||||
CurrentPage = options.Page,
|
||||
Items = stars,
|
||||
PageSize = options.PageSize,
|
||||
TotalItems = count,
|
||||
TotalPages = count == 0 ? 0 : count / pageSize
|
||||
TotalPages = (int)Math.Ceiling(Math.Max(0, count) / (double)options.PageSize)
|
||||
};
|
||||
}
|
||||
|
||||
[HttpGet("{id:int}")]
|
||||
[Authorize(Policy = "permissions:admin.servers.stars.read")]
|
||||
public async Task<StarDetailResponse> GetSingle([FromRoute] int id)
|
||||
public async Task<ActionResult<StarResponse>> GetSingle([FromRoute] int id)
|
||||
{
|
||||
var star = await StarRepository
|
||||
.Get()
|
||||
.AsNoTracking()
|
||||
.ProjectToAdminResponse()
|
||||
.FirstOrDefaultAsync(x => x.Id == id);
|
||||
|
||||
if (star == null)
|
||||
throw new HttpApiException("No star with that id found", 404);
|
||||
return Problem("No star with that id found", statusCode: 404);
|
||||
|
||||
return StarMapper.ToAdminResponse(star);
|
||||
return star;
|
||||
}
|
||||
|
||||
[HttpPost]
|
||||
[Authorize(Policy = "permissions:admin.servers.stars.create")]
|
||||
public async Task<StarDetailResponse> Create([FromBody] CreateStarRequest request)
|
||||
public async Task<ActionResult<StarResponse>> Create([FromBody] CreateStarRequest request)
|
||||
{
|
||||
var star = StarMapper.ToStar(request);
|
||||
|
||||
@@ -95,7 +93,7 @@ public class StarsController : Controller
|
||||
|
||||
[HttpPatch("{id:int}")]
|
||||
[Authorize(Policy = "permissions:admin.servers.stars.update")]
|
||||
public async Task<StarDetailResponse> Update(
|
||||
public async Task<ActionResult<StarResponse>> Update(
|
||||
[FromRoute] int id,
|
||||
[FromBody] UpdateStarRequest request
|
||||
)
|
||||
@@ -105,7 +103,7 @@ public class StarsController : Controller
|
||||
.FirstOrDefaultAsync(x => x.Id == id);
|
||||
|
||||
if (star == null)
|
||||
throw new HttpApiException("No star with that id found", 404);
|
||||
return Problem("No star with that id found", statusCode: 404);
|
||||
|
||||
StarMapper.Merge(request, star);
|
||||
await StarRepository.Update(star);
|
||||
@@ -115,15 +113,16 @@ public class StarsController : Controller
|
||||
|
||||
[HttpDelete("{id:int}")]
|
||||
[Authorize(Policy = "permissions:admin.servers.stars.delete")]
|
||||
public async Task Delete([FromRoute] int id)
|
||||
public async Task<ActionResult> Delete([FromRoute] int id)
|
||||
{
|
||||
var star = await StarRepository
|
||||
.Get()
|
||||
.FirstOrDefaultAsync(x => x.Id == id);
|
||||
|
||||
if (star == null)
|
||||
throw new HttpApiException("No star with that id found", 404);
|
||||
return Problem("No star with that id found", statusCode: 404);
|
||||
|
||||
await StarRepository.Remove(star);
|
||||
return NoContent();
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user